Support string list filters #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
improvement/support-string-list-filters
branch
from
0f59997 to
d827544
Compare
stevelacey
changed the title
stevelacey
force-pushed
the
improvement/support-string-list-filters
branch
from
d827544 to
688e227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Swaps out the bundle validation of query params in favor of letting django/url_filter deal with it, and adds support for
AND's via passing multiple of the same key i.e.?skill=1&skill=2ala talent search v1.Note: this switches
?skill=1&skill=2from performing anORto performing anAND. To perform aninquery pass?skill__in=1&skill_in=2or the shorthand of?skill__in=1,2. As far as I can seestaff job searchis the only thing doing this, and in the case ofskillsanandis probably what is wanted anyway.Where should the reviewer start?
List api filters.
Why is this important, or what issue does this solve?
Logical ands were not possible and we only supported lists of integers.
What Worf gif best describes this PR or how it makes you feel?
Definition of Done:
READMEupdates reflecting any new features/improvements to the framework