Support custom queryset on detail views #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
improvement/detail-queryset
branch
from
727e79d to
ed421a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds support for supplying a custom queryset directly on a detail or via overriding the
get_querysetmethod.Also drops the internal usage of
get_instance_or_http404which I suspect doesn't add value anymore now thatdispatchcatchesObjectDoesNotExist... though I haven't made sure, but the tests would fail right. Right?Why is this important, or what issue does this solve?
Sometimes
model.objects.all()isn't enough, maybe you wanna apply some filters, or pull the queryset off of arequest.userrelation.Also this is already supported on list views.
Where should the reviewer start?
Detail views.
What Worf gif best describes this PR or how it makes you feel?
Tasks