Switch search fields to list #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
improvement/switch-search-fields-to-list
branch
3 times, most recently
from
246377f to
178f280
Compare
|
Does this solve #48 ? |
stevelacey
force-pushed
the
improvement/switch-search-fields-to-list
branch
3 times, most recently
from
d6aeae5 to
d7e769f
Compare
Yes |
stevelacey
force-pushed
the
improvement/switch-search-fields-to-list
branch
2 times, most recently
from
95c0421 to
06076dd
Compare
stevelacey
force-pushed
the
improvement/switch-search-fields-to-list
branch
from
06076dd to
9a23814
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Search fields is confusing and half broken; the
ANDwas being discarded, and theORwas not contained in a way that applying anANDto it would have worked anyway, which is maybe why it got removed.This switches
search_fieldsto a simplelistinstead of a confusingdictand tweaks howq_objectsis built.Backwards compatibility with the old
ordict is maintained, theandcontinues to be ignored, docs have been updated to describe that this attribute should be a list.Where should the reviewer start?
View tests / query params.
Why is this important, or what issue does this solve?
Search fields was confusing and not working in some scenarios.
What Worf gif best describes this PR or how it makes you feel?
Tasks
READMEupdates reflecting any new features/improvements to the framework