Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Add support for decimal fields #179

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

regiscamimura
Copy link
Contributor

What does this PR do?

This adds validation for decimals so we can use them 🙄

What Worf gif best describes this PR or how it makes you feel?

Checklist

  • This PR increases test coverage

@regiscamimura regiscamimura force-pushed the feature/support-decimals branch from bf201f9 to 832deac Compare October 13, 2023 17:01
@regiscamimura regiscamimura requested a review from jciskey October 13, 2023 17:01
Copy link

@jciskey jciskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern w.r.t. how we're doing the validation, otherwise this looks good.

worf/validators.py Outdated Show resolved Hide resolved
@regiscamimura regiscamimura requested a review from jciskey October 13, 2023 17:54
Copy link

@jciskey jciskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regiscamimura regiscamimura force-pushed the feature/support-decimals branch from 3bfbb46 to 32f422d Compare October 13, 2023 18:07
@regiscamimura regiscamimura merged commit 7a9933c into master Oct 13, 2023
@regiscamimura regiscamimura deleted the feature/support-decimals branch October 13, 2023 18:09
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants