Fall back to default model ordering when no override provided in ListView #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, it looks like this is already working in master. You can see #157 if you like. Thank you for your submission, though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where a Model.ordering would not be applied if no ListView.ordering was provided.
What issue does this solve?
#95
Where should the reviewer start?
The
test_profile_list_default_model_orderingtest provides a reproducer, while the fix is inworf/views/list.pyWhat Worf gif best describes this PR or how it makes you feel?
Checklist
READMEupdates reflecting any new features/improvements to the framework