(Improvement) Switch out PermissionsError for reraise with extended message #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
improvement/reraise-permission-errors
branch
from
d7c2b74 to
b241bc0
Compare
stevelacey
force-pushed
the
improvement/reraise-permission-errors
branch
2 times, most recently
from
61dfd56 to
7d44f5f
Compare
stevelacey
force-pushed
the
improvement/reraise-permission-errors
branch
from
7d44f5f to
eb42db1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches away from overriding the intended permission exception with the generic PermissionsError when
WORF_DEBUG=True.This means that 500's no longer happen in dev and instead the expected 4xx error is returned but with a longer message to aid debugging.