reduce nesting per review

gulpjs · Aug 5, 2014 · a73458e · a73458e
1 parent cf8e5fd
commit a73458e
Showing 1 changed file with 19 additions and 16 deletions.
diff --git a/lib/dest/writeContents/index.js b/lib/dest/writeContents/index.js
@@ -6,26 +6,29 @@ var writeStream = require('./writeStream');
 var writeBuffer = require('./writeBuffer');
 
 function writeContents(writePath, file, cb) {
-  var written = function(err){
+  var written = function(err) {
     var done = function(err) {
       cb(err, file);
     };
-    if (!err) {
-      if (file.stat && typeof file.stat.mode === 'number') {
-        fs.stat(writePath, function(err, st) {
-          if (err) {
-            return done(err);
-          }
-          // octal 7777 = decimal 4095
-          if ((st.mode & 4095) === file.stat.mode) {
-            return done();
-          }
-          fs.chmod(writePath, file.stat.mode, done);
-        });
-        return;
-      }
+    if (err) {
+      return done(err);
+    }
+
+    if (!file.stat || typeof file.stat.mode !== 'number') {
+      return done();
     }
-    done(err);
+
+    fs.stat(writePath, function(err, st) {
+      if (err) {
+        return done(err);
+      }
+      // octal 7777 = decimal 4095
+      var currentMode = (st.mode & 4095);
+      if (currentMode === file.stat.mode) {
+        return done();
+      }
+      fs.chmod(writePath, file.stat.mode, done);
+    });
   };
 
   // if directory then mkdirp it