deps: update chokidar to 3.x

[MylesBorins]

The current version of chokidar used by this project is broken on
Node.js v12.x and v14.x. Updating this version fixes the problem.

Fixes: #58
Fixes: #55
Fixes: #49

[phated]

This introduces a breaking change to our compatibility matrix and requires major bumps throughout the system. Half of that work is already in flight.

[MylesBorins]

@phated totally understand. In the meantime we are likely going to have to remove gulp for the testing matrix for v14 and v12. The change that landed that broke the test suite is a change to the internals of async_hooks, an unrealted API. Gulp's test suite still seems to pass on 12.x... but for some reason that single change broke the suite on 14.

When testing glob-watcher it seems like it has consistenly been broken on 14 with pretty serious abort errors. I'm trying to track down which change on 12.x caused things to start breaking

[phated]

@MylesBorins are you sure the async_hooks thing isn't our use of domains? As opposed to this issue.

[terinjokes]

The current version of chokidar used by this project is broken on Node.js v12.x

Gulp's test suite still seems to pass on 12.x

I'm a bit confused. Is there a way to see these test runs somewhere?

[MylesBorins]

@terinjokes to reproduce (on OSX only)

$ nvm install 12.18.2
$ git clone https://github.com/gulpjs/glob-watcher.git
$ cd glob-watcher
$ npm install
$ npm test

output

> [email protected] pretest /Users/*/*/glob-watcher
> npm run lint


> [email protected] lint /Users/*/*/glob-watcher
> eslint .


> [email protected] test /Users/*/*/glob-watcher
> mocha --async-only



  glob-watcher
    ✓ only requires a glob and returns watcher (127ms)
    ✓ picks up added files (111ms)
    ✓ works with OS-specific cwd (111ms)
    ✓ accepts a callback & calls when file is changed (317ms)
    ✓ accepts a callback & calls when file is added (313ms)
    1) waits for completion is signaled before running again
Assertion failed: (0), function uv_close, file ../deps/uv/src/unix/core.c, line 178.
Abort trap: 6

For v14.x

$ nvm install 14.5.0
$ git clone https://github.com/gulpjs/glob-watcher.git
$ cd glob-watcher
$ npm install
$ npm test

output

> [email protected] pretest /Users/*/*/glob-watcher
> npm run lint


> [email protected] lint /Users/*/*/glob-watcher
> eslint .


> [email protected] test /Users/*/*/glob-watcher
> mocha --async-only

  glob-watcher
    ✓ only requires a glob and returns watcher (127ms)
    ✓ picks up added files (111ms)
    ✓ works with OS-specific cwd (111ms)
    ✓ accepts a callback & calls when file is changed (313ms)
    ✓ accepts a callback & calls when file is added (315ms)
    ✓ waits for completion is signaled before running again (917ms)
    1) can signal completion with a stream
Assertion failed: (0), function uv_close, file ../deps/uv/src/unix/core.c, line 178.
Abort trap: 6

[MylesBorins]

FYI, I'm going to be skipping gulp for CITGM on darwin based hosts until we sort this out (either in core or in gulp).

nodejs/citgm#814

[phated]

Preferring #61 over this one - it looks like there's a bunch wrong with upgrading our deps.