Implementing node-glob's `ignore` option, fixes #24 #40

UltCombo · 2015-02-24T04:19:37Z

Quite a few tests are broken on my machine, not sure if I'm missing something or the ignore option is buggy in regard to the dot option and absolute paths (on Windows).

Fixes #24

Quite a few tests are broken on my machine, not sure if I'm missing something or the `ignore` option is buggy in regard to the `dot` option and absolute paths (on Windows).

yocontra · 2015-02-24T04:22:31Z

Actually if it cleans up the code lets go ahead and remove regexp support, I've never seen anyone use it. No need to keep that feature - it isn't even documented well afaik

UltCombo · 2015-02-24T04:27:30Z

Something odd is that Mocha was seemingly "cascading" certain test fails -- e.g. in my first commit above, the "glob-stream create() should handle RegExps as negative matchers" test shows up as a fail, but it passes when run in isolation.

yocontra · 2015-02-24T04:30:17Z

index.js

+    if (negatives.length) {
+      // Do not mutate the options object which may be used
+      // in multiple `gs.createStream()` calls.
+      opt = assign({}, opt);


wouldnt a lodash.clone be better here?

I tend to use object-assign as its logic is rather simple and well-spec'd (follows ECMAScript 2015 spec.). But yes, I guess a clone or cloneDeep would suffice as well.

Should I add the entire lodash lib as a dependency or just the clone method?

UltCombo · 2015-02-24T04:31:00Z

I've removed RegExp support, but no change in the failed tests. I wonder if it is an issue with glob's ignore option, or if I'm just too sleepy to see an obvious error.

yocontra · 2015-02-24T04:31:42Z

index.js

      globArray.push({
        index: index,
-        glob: glob
+        glob: globArray === negatives ? glob.slice(1) : glob


should just be isNegative(glob) ? glob.slice(1) : glob then ditch the globArray var

what about the globArray.push above? Should I inline (isNegative(glob) ? glob.slice(1) : glob).push() as well?

i would put isNegative in a var so it only gets called once then ternary the other two places

UltCombo · 2015-02-24T04:35:30Z

Oh -- I'm forgetting to unrelative the negative globs, doh.

UltCombo · 2015-02-24T04:54:51Z

Looks like there is still an issue with unrelative logic.

UltCombo · 2015-02-24T04:59:49Z

Oh wait, the unrelative logic is fine -- node-glob's ignore option seems to be screwing it up independent of using relative or absolute paths.

UltCombo · 2015-02-24T23:25:13Z

"should return a file name stream with dotfiles negated" is failing due to a node-glob issue.

UltCombo · 2015-02-25T02:38:46Z

I thought the error could be due to passing absolute paths (which use \ as dir separator in Windows) to the ignore option (according to the docs, node-glob always interprets \ as escape sequences).

Minimatch@2 does treat \ as a valid dir separator, but node-glob currently does not.

The test is still failing on Travis (Linux), so there must be yet another error...

yocontra · 2015-03-16T15:57:15Z

Any progress on this?

UltCombo · 2015-03-16T16:09:52Z

@contra there are some blocking issues:

Awaiting @isaacs's feedback on ignore option doesn't work with the dot option isaacs/node-glob#166 (comment)
It also seems like node-glob was not supposed to work with absolute paths like glob-stream does currently (mainly, absolute Windows paths). I tried rewriting the logic to resolve the paths after the glob matching step, but that also broke quite a few tests.

UltCombo · 2015-03-16T16:16:25Z

@contra If you don't mind the breaking change regarding the dot behavior, we can skip those tests temporarily and I can try fixing the remaining logic again.

yocontra · 2015-09-14T01:21:20Z

@UltCombo Seems like the resolution from the glob issue was the ball is in your court. Do you need any help with this?

isaacs/node-glob#166 (comment)

UltCombo · 2015-09-14T01:30:26Z

@contra Well yes, I have near to no experience with the node-glob code base, and a good part of it seems nearly unreadable to me.

thirdcreed · 2015-11-21T15:50:40Z

I nearly have a working PR for this, there's one test broken:
'should return a file name stream with dotfiles negated'
and it's timing out at 2000ms.

Any thoughts on what that might be, for some reason the stream is not emitting anything.
https://github.com/thirdcreed/glob-stream/blob/master/index.js

thirdcreed · 2015-11-23T18:49:20Z

isaacs/node-glob#232 This is a block for me. I think there's some bigger problem involving globs that end with "/**", a completely different matcher is used for those cases. There's some kind of race condition. It emits before the on end event is registered.

thirdcreed · 2015-11-25T04:38:31Z

I'm going to wait until issacs has time to answer it, I guess this above my head. Apparently the race condition thing is understood, It looks like its on the user to guarantee their events. Unless issacs has some insight on why their would be a race condition on the this one end event, in this one edge case. I’m out of ideas. I've been hacking on my own node-glob, but I can't seem to get that one fucking test to run.

It looks like @UltCombo's on this again anyway.

UltCombo · 2015-11-25T12:13:45Z

There are 23 failing tests (on both current master and @thirdcreed's branch) when testing on Windows. This does not make it easy to work on a fix and I'm relatively short on free time.

I guess I can give this another shot on my Linux or Mac box soon.

@contra May I suggest adding AppVeyor (Windows CI)? Here's a sample appveyor.yml just in case.

yocontra · 2015-11-26T04:11:15Z

@UltCombo We use appveyor on some other stuff, feel free to add it if you need it

UltCombo · 2015-11-26T12:25:01Z

@contra Do you have an appveyor config of your choice to add to this repository? Or should I just create one using the same Node.js versions as this repo's Travis config?

phated · 2015-11-27T17:31:28Z

https://github.com/gulpjs/gulp-cli/blob/master/appveyor.yml

jonschlinkert · 2015-12-17T11:18:46Z

Something odd is that Mocha was seemingly "cascading" certain test fails

if there are multiple tests with the same description, mocha will run them all, even if one has .only on it. I remember this driving me crazy a few times before @doowb noticed what was happening and pointed it out. again, not sure if it's related. but if not, maybe it will save someone else from going crazy lol.

phated · 2016-09-07T23:40:57Z

Closing in favor of #71 which is passing all the tests. Thanks for putting in a lot of the work here @UltCombo

UltCombo · 2016-09-08T03:44:45Z

Oh, this was still on my TODO list, but kept falling off the radar.

No problem, and indeed, #71 seems more suitable and up-to-date. I'll comment there if I find anything odd.

Implementing node-glob's ignore option

4db4033

Quite a few tests are broken on my machine, not sure if I'm missing something or the `ignore` option is buggy in regard to the `dot` option and absolute paths (on Windows).

remove RegExp support

fff4f8e

yocontra reviewed Feb 24, 2015
View reviewed changes

clean up, respond to review

34cd575

UltCombo changed the title ~~Implementing node-glob's ignore option~~ Implementing node-glob's ignore option, fixes #24 Feb 24, 2015

clean up

6ea6ad3

try out fix branch

90f6a36

UltCombo mentioned this pull request Sep 14, 2015

Using src globs can be really slow with negation #24

Closed

yocontra mentioned this pull request Oct 1, 2015

gulp.src ignore option does not match documentation gulpjs/gulp#1296

Closed

phated closed this Sep 7, 2016

UltCombo mentioned this pull request Sep 8, 2016

Breaking: Upgrade to glob 7, implement ignore & remove RegExp as negative matchers (closes #24, closes #57) #71

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing node-glob's `ignore` option, fixes #24 #40

Implementing node-glob's `ignore` option, fixes #24 #40

UltCombo commented Feb 24, 2015

yocontra commented Feb 24, 2015

UltCombo commented Feb 24, 2015

yocontra Feb 24, 2015

UltCombo Feb 24, 2015

UltCombo Feb 24, 2015

UltCombo Feb 24, 2015

UltCombo commented Feb 24, 2015

yocontra Feb 24, 2015

UltCombo Feb 24, 2015

yocontra Feb 24, 2015

UltCombo Feb 24, 2015

UltCombo commented Feb 24, 2015

UltCombo commented Feb 24, 2015

UltCombo commented Feb 24, 2015

UltCombo commented Feb 24, 2015

UltCombo commented Feb 25, 2015

yocontra commented Mar 16, 2015

UltCombo commented Mar 16, 2015

UltCombo commented Mar 16, 2015

yocontra commented Sep 14, 2015

UltCombo commented Sep 14, 2015

thirdcreed commented Nov 21, 2015

thirdcreed commented Nov 23, 2015

thirdcreed commented Nov 25, 2015

UltCombo commented Nov 25, 2015

yocontra commented Nov 26, 2015

UltCombo commented Nov 26, 2015

phated commented Nov 27, 2015

jonschlinkert commented Dec 17, 2015

phated commented Sep 7, 2016

UltCombo commented Sep 8, 2016

Implementing node-glob's ignore option, fixes #24 #40

Implementing node-glob's ignore option, fixes #24 #40

Conversation

UltCombo commented Feb 24, 2015

yocontra commented Feb 24, 2015

UltCombo commented Feb 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UltCombo commented Feb 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UltCombo commented Feb 24, 2015

UltCombo commented Feb 24, 2015

UltCombo commented Feb 24, 2015

UltCombo commented Feb 24, 2015

UltCombo commented Feb 25, 2015

yocontra commented Mar 16, 2015

UltCombo commented Mar 16, 2015

UltCombo commented Mar 16, 2015

yocontra commented Sep 14, 2015

UltCombo commented Sep 14, 2015

thirdcreed commented Nov 21, 2015

thirdcreed commented Nov 23, 2015

thirdcreed commented Nov 25, 2015

UltCombo commented Nov 25, 2015

yocontra commented Nov 26, 2015

UltCombo commented Nov 26, 2015

phated commented Nov 27, 2015

jonschlinkert commented Dec 17, 2015

phated commented Sep 7, 2016

UltCombo commented Sep 8, 2016

Implementing node-glob's `ignore` option, fixes #24 #40

Implementing node-glob's `ignore` option, fixes #24 #40