Skip to content

Commit

Permalink
gnu: go-1.21: Skip tests with time bomb.
Browse files Browse the repository at this point in the history
As seen in <https://ci.guix.gnu.org/build/7713190/log/raw>.
Certificates which are used in tests are not valid after Jan 1 00:00:00
2025 GMT, Happy New Year!.
See <golang/go#71077>.

* gnu/packages/golang.scm (go-1.21) [arguments] <phases>: Add
'skip-crypto-tls-tests.

Change-Id: Id9f8ad93201aedae4f4451ee8b7b9cf40cd33cdb
  • Loading branch information
Hellseher committed Jan 9, 2025
1 parent 5080487 commit a03f9c8
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions gnu/packages/golang.scm
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,24 @@ in the style of communicating sequential processes (@dfn{CSP}).")
#~(modify-phases #$phases
(delete 'skip-TestGoPathShlibGccgo-tests)
(delete 'patch-source)
;; Time bomb in TLS tests: "Most of the test certificates
;; (e.g. testRSACertificate, testRSACertificateIssuer,
;; testRSA2048CertificateIssuer) have a not after of Jan 1
;; 00:00:00 2025 GMT."
;; https://github.com/golang/go/issues/71077
;; https://github.com/golang/go/issues/71103
;; https://github.com/golang/go/issues/71104
(add-after 'unpack 'skip-crypto-tls-tests
(lambda _
(substitute* (list "src/crypto/tls/handshake_client_test.go"
"src/crypto/tls/handshake_server_test.go")
(("TestVerifyConnection.*" all)
(string-append all "\n t.Skip(\"golang.org/issue/71077\")\n"))
(("TestResumptionKeepsOCSPAndSCT.*" all)
(string-append all "\n t.Skip(\"golang.org/issue/71077\")\n"))
(("TestCrossVersionResume.*" all)
(string-append all "\n t.Skip(\"golang.org/issue/71077\")\n")))))

(add-after 'unpack 'patch-os-tests
(lambda _
(substitute* "src/os/os_test.go"
Expand Down

0 comments on commit a03f9c8

Please sign in to comment.