compile strings etc as regexes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is good to go. It happens. to fix an enum quoting issue that's present on |
Awesome, will try to review today! |
hudson-ai
reviewed
Jan 5, 2025
parser/src/json/compiler.rs
Outdated
Comment on lines
525
to
530
| // TODO: is this special case needed? | ||
| Schema::Number { | ||
| minimum: Some(x), | ||
| maximum: Some(y), | ||
| .. | ||
| } if x == y => Some(RegexAst::Literal(x.to_string())), |
There was a problem hiding this comment.
Can this special case actually get us into trouble, e.g. if min == max, but exclusiveMinimum > minimum, or if min == max is a non-integer, but we have integer=True?
Btw I'm open to changing our representation to exclusive{Minumum,Maximum} being bools if it simplifies things.
|
Bar my one comment, lgtm! |
hudson-ai
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hudson-ai for awareness; still WIP!