Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3754. UICatalog throws System.NullReferenceException on MenuBar in Linux. #3755

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 24, 2024

Fixes

Proposed Changes/Todos

  • IsEnabled method now checks for null MenuItem.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner September 24, 2024 13:37
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix. Thanks.

@tig tig merged commit 85fcbdf into gui-cs:v2_develop Sep 24, 2024
4 checks passed
@BDisp BDisp deleted the v2_3754_menuitem-null-fix branch September 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UICatalog throws System.NullReferenceException on MenuBar in Linux.
2 participants