-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2921 - MainLoop refactoring #2922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BDisp
suggested changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tig please see my comments.
BDisp
suggested changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tig please see my comments. Thanks.
BDisp
reviewed
Oct 19, 2023
BDisp
reviewed
Oct 19, 2023
BDisp
reviewed
Oct 19, 2023
BDisp
suggested changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2921
IMainLoopDriver and ConsoleDriver were originally designed to be decoupled by Miguel to enable pluggabiliy he imagined. We've learned that all driver implementations end up tightly coupling them.
As a result there is a bunch of complexity (and potential for bugs like #2921) that could be removed by simplifying the design.
This PR will attempt to do this.
Action
based events on ConsoleDriver/Application to use the properEventHandler
patternMainLoop
,IMainLoopDriver
etc... internal implementation details, exposing curical methods/events onApplication
instead. Note this effectively means 3rd parties cannot buildConsoleDriver
implementations; that's ok because nobody's ever done that anyway.PrepareToRun
and getting rid of more duplicated code.Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)