Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2053. MessageBox.Query not wrapping correctly #2054

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 21, 2022

Fixes #2053 - I copied the Help menu from the UICatalog and pasted into the StandaloneExample net6.0 project which use the 1.8.0 nuget package to prove MessageBox text wrapping is working fine. The problem was the dialog size was exceeding the console size.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

imagem

@BDisp BDisp force-pushed the standalone-help-menu-added branch from fff7331 to 671fa7d Compare September 21, 2022 17:46
@tig tig merged commit 2ed7a0c into gui-cs:develop Sep 21, 2022
@tig tig changed the title Fixes #2053. I am still having this issue with v1.8.0 on windows/net6.0. Fixes #2053. MessageBox.Query not wrapping correctly Sep 21, 2022
@BDisp BDisp deleted the standalone-help-menu-added branch September 21, 2022 21:49
@tig tig mentioned this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageBox.Query still not wrapping with v1.8.0 on windows/net6.0.
2 participants