Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2026. Added ClearOnVisibleFalse to flag if the view must be cleared or not. #2020

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Fixes #2026. Added ClearOnVisibleFalse to flag if the view must be cleared or not. #2020

merged 2 commits into from
Sep 16, 2022

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 16, 2022 •
edited
Loading

Fixes #2026- Added a flag to set if a view can be cleared if the Visible property is false, the default is true.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp force-pushed the view-visible-flag-to-clear-or-not-fix branch 2 times, most recently from bf144ef to 38dc6b5 Compare September 16, 2022 14:57
@BDisp BDisp force-pushed the view-visible-flag-to-clear-or-not-fix branch from 38dc6b5 to dfcccff Compare September 16, 2022 15:04
@BDisp BDisp changed the title Fixes #1984. Added ClearOnVisibleFalse to flag if the view must be cleared or not. Fixes #2026. Added ClearOnVisibleFalse to flag if the view must be cleared or not. Sep 16, 2022
tig
tig approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tig tig merged commit 281a849 into gui-cs:develop Sep 16, 2022
@BDisp BDisp deleted the view-visible-flag-to-clear-or-not-fix branch September 16, 2022 16:24
@BDisp BDisp restored the view-visible-flag-to-clear-or-not-fix branch September 16, 2022 18:30
@BDisp BDisp deleted the view-visible-flag-to-clear-or-not-fix branch September 16, 2022 18:53
@BDisp BDisp mentioned this pull request Sep 16, 2022
Closed
8 tasks
@BDisp BDisp restored the view-visible-flag-to-clear-or-not-fix branch September 16, 2022 21:16
@BDisp BDisp deleted the view-visible-flag-to-clear-or-not-fix branch September 16, 2022 21:17
@tig tig mentioned this pull request Sep 17, 2022
Closed
6 tasks
@renovate renovate bot mentioned this pull request Sep 19, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig tig approved these changes

@migueldeicaza migueldeicaza Awaiting requested review from migueldeicaza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a a flag to set if the view must be cleared or not on Visible as false.
2 participants
@BDisp @tig