Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2014. Application mouseGrabView is run twice if return true. #2015

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Fixes #2014. Application mouseGrabView is run twice if return true. #2015

merged 2 commits into from
Sep 16, 2022

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 15, 2022

Fixes #2014 - When the mouseGrabView return true from the mouse event then it must return to the caller method, instead of re-run on the next statement.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp marked this pull request as draft September 15, 2022 19:44
@BDisp BDisp marked this pull request as ready for review September 15, 2022 19:44
@tig
Copy link
Collaborator

tig commented Sep 16, 2022

@BDisp please fix merge conflicts. Thanks.

@BDisp BDisp force-pushed the mouseGrabView-run-twice-fix branch from fb04eba to e3d79b1 Compare September 16, 2022 14:25
@BDisp
Copy link
Collaborator Author

BDisp commented Sep 16, 2022

@BDisp please fix merge conflicts. Thanks.

Done. Thanks for remember that.

@tig tig merged commit f57e48b into gui-cs:develop Sep 16, 2022
@BDisp BDisp deleted the mouseGrabView-run-twice-fix branch September 16, 2022 14:38
This was referenced Sep 17, 2022
Closed
Closed
tig pushed a commit to tig/Terminal.Gui that referenced this pull request Sep 17, 2022
@BDisp @tig
Fixes gui-cs#2014. Application mouseGrabView is run twice if return t…
88c6bfb 
…rue. (gui-cs#2015)

* Fixes gui-cs#2014. Application mouseGrabView is run twice if return true.

* Sometimes I get fails with this unit test.
@renovate renovate bot mentioned this pull request Sep 19, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldeicaza migueldeicaza Awaiting requested review from migueldeicaza

@tig tig Awaiting requested review from tig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application mouseGrabView is run twice if return true.
2 participants
@BDisp @tig