-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1963. Only remove one character on backspace when wordwrap is on #1964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent find and fix. Thank you.
Once you fix the source formatting I'll merge.
@hippiehunter, per @BDisp can you please also fix the Delete key use-case as part of this PR? Many thanks for helping with this! |
@tig this bug is much more wide than this pr is intended for. Because now all the actions on the |
…h WordWrap enabled.
@tig here is my fix https://github.com/BDisp/Terminal.Gui/tree/textview-word-wrap-delete-backwards-forwards-fix. @hippiehunter can merge into his pr or if you want I can create a new pr with my branch. Thanks. |
Is there anything else you need me to do on this PR? |
For me, since you already merged my fix I think is all OK and I already approved. I appreciate your help for found this issue, but the fix implied more some changes. The management for remove and add runes on wrapped lines aren't need anymore and that why it was deleting twice when word wrap is enabled We must wait for @tig to merge or saying something. Thanks. |
Fixes #1963 check if word wrap is enabled before removing the character from the model. If its enabled, use the wrap manager instead.