Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docfx - revert hack for 1874 #1955

Merged
merged 19 commits into from
Sep 16, 2022
Merged

Docfx - revert hack for 1874 #1955

merged 19 commits into from
Sep 16, 2022

Conversation

tig
Copy link
Collaborator

@tig tig commented Aug 17, 2022

This PR should be merged after dotnet/msbuild#7832 has been fixed.

Fixes #1874

@tig
Copy link
Collaborator Author

tig commented Aug 17, 2022

The docs should be regnerated with ./docfx/build.ps1 before actually merging this PR!

@tig tig marked this pull request as draft September 5, 2022 14:16
@tig tig marked this pull request as ready for review September 16, 2022 12:49
@tig
Copy link
Collaborator Author

tig commented Sep 16, 2022

Per https://github.com/dotnet/docfx/releases/tag/v2.59.4, the docfx team implemented a workaround to the core MSBuild issue (dotnet/msbuild#7680) in DocFx v2.59.4.

I have confirmed that our docs now build correctly with docfx v2.59.4 and this PR.

@tig tig merged commit 7a48424 into gui-cs:develop Sep 16, 2022
@tig tig deleted the docfx_revert_hack_for_1874 branch September 16, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocFx must use hacky/slow work around due to bug in VS2022 17.3
1 participant