TextField selected text does not draw in v2

[tig]

None of these extend functions are working in v2.

They do seem to work in TextView FWIW.

This is weird because there are unit tests, and they pass:

[Fact]
[TextFieldTestsAutoInitShutdown]
public void WordBackward_With_Selection ()
{
	_textField.CursorPosition = _textField.Text.Length;
	_textField.SelectedStart = _textField.Text.Length;
	var iteration = 0;

	while (_textField.CursorPosition > 0) {
		_textField.ProcessKey (new KeyEvent (Key.CursorLeft | Key.CtrlMask | Key.ShiftMask, new KeyModifiers ()));
		switch (iteration) {
		case 0:
			Assert.Equal (25, _textField.CursorPosition);
			Assert.Equal (32, _textField.SelectedStart);
			Assert.Equal (7, _textField.SelectedLength);
			Assert.Equal ("fields.", _textField.SelectedText);
			break;
		case 1:
			Assert.Equal (20, _textField.CursorPosition);
			Assert.Equal (32, _textField.SelectedStart);
			Assert.Equal (12, _textField.SelectedLength);
			Assert.Equal ("text fields.", _textField.SelectedText);
			break;
		case 2:
			Assert.Equal (12, _textField.CursorPosition);
			Assert.Equal (32, _textField.SelectedStart);
			Assert.Equal (20, _textField.SelectedLength);
			Assert.Equal ("between text fields.", _textField.SelectedText);
			break;
		case 3:
			Assert.Equal (7, _textField.CursorPosition);
			Assert.Equal (32, _textField.SelectedStart);
			Assert.Equal (25, _textField.SelectedLength);
			Assert.Equal ("jump between text fields.", _textField.SelectedText);
			break;
		case 4:
			Assert.Equal (4, _textField.CursorPosition);
			Assert.Equal (32, _textField.SelectedStart);
			Assert.Equal (28, _textField.SelectedLength);
			Assert.Equal ("to jump between text fields.", _textField.SelectedText);
			break;
		case 5:
			Assert.Equal (0, _textField.CursorPosition);
			Assert.Equal (32, _textField.SelectedStart);
			Assert.Equal (32, _textField.SelectedLength);
			Assert.Equal ("TAB to jump between text fields.", _textField.SelectedText);
			break;
		}
		iteration++;
	}
}

To repro, run the "Text Input Controls" scenario and try to use CTRL-SHIFT-RightArrow.

This is v2_develop.

In this video I am using Ctrl-Shift-Right/Left arrow. Notice that autocomplete is suggesting "TextView" and when it does the extend functionally WANTS to work. This suggests the bug has something to do with autocomplete.

[BDisp]

In this video I am using Ctrl-Shift-Right/Left arrow. Notice that autocomplete is suggesting "TextView" and when it does the extend functionally WANTS to work. This suggests the bug has something to do with autocomplete.

No it isn't. The culprit is in the PrepareSelection method by not set the SetNeedsDisplay in the case where the selected text is changed.

		void PrepareSelection (int x, int direction = 0)
		{
			x = x + _first < -1 ? 0 : x;
			_selectedStart = _selectedStart == -1 && _text.Count > 0 && x >= 0 && x <= _text.Count ? x : _selectedStart;
			if (_selectedStart > -1) {
				_length = Math.Abs (x + direction <= _text.Count ? x + direction - _selectedStart : _text.Count - _selectedStart);
				SetSelectedStartSelectedLength ();
				if (_start > -1 && _length > 0) {
					_selectedText = _length > 0 ? StringExtensions.ToString (_text.GetRange (
						_start < 0 ? 0 : _start, _length > _text.Count ? _text.Count : _length)) : "";
					if (_first > _start) {
						_first = _start;
					}
				} else if (_start > -1 && _length == 0) {
					_selectedText = null;
				}
			} else if (_length > 0 || _selectedText != null) {
				ClearAllSelection ();
			}
			Adjust ();
		}

[BDisp]

There is needed to have a unit test to check the colors of the selected text, otherwise it never fail.

[tig]

There is needed to have a unit test to check the colors of the selected text, otherwise it never fail.

I need to be able to test this in #2927 so I've fixed it there. see c948d030