Skip to content

Commit

Permalink
github+Docker: bump and fix go version to 1.16.9
Browse files Browse the repository at this point in the history
There's a race condition in the h2_bundle.go of go 1.16.10 and later. The
issue golang/go#51799 mentions that this might
be fixed in go 1.19, so we'll need to wait for that.
We make sure we build our docker images with go 1.16.9 to not run into
the issue in the wild.
  • Loading branch information
guggero committed Mar 25, 2022
1 parent 729631f commit 19f91ae
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ env:

# If you change this value, please change it in the following files as well:
# /Dockerfile
GO_VERSION: 1.17.8
#
# Don't bump this until go 1.19 is out (which should include a fix for
# https://github.com/golang/go/issues/51799). There was a race condition
# introduced with go 1.16.10 that causes the unit tests to fail (could also
# happen in production).
GO_VERSION: 1.16.9

jobs:
########################
Expand Down Expand Up @@ -48,7 +53,7 @@ jobs:
- name: setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v2
with:
go-version: '~${{ env.GO_VERSION }}'
go-version: '${{ env.GO_VERSION }}'

- name: lint
run: make lint
Expand Down Expand Up @@ -83,7 +88,7 @@ jobs:
- name: setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v2
with:
go-version: '~${{ env.GO_VERSION }}'
go-version: '${{ env.GO_VERSION }}'

- name: run ${{ matrix.unit_type }}
run: make ${{ matrix.unit_type }}
6 changes: 5 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
FROM golang:1.15.5-alpine as builder
# Don't bump this until go 1.19 is out (which should include a fix for
# https://github.com/golang/go/issues/51799). There was a race condition
# introduced with go 1.16.10 that causes the unit tests to fail (could also
# happen in production).
FROM golang:1.16.9-alpine as builder

# Force Go to use the cgo based DNS resolver. This is required to ensure DNS
# queries required to connect to linked containers succeed.
Expand Down

0 comments on commit 19f91ae

Please sign in to comment.