-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Degeneralize server and client generators #1785
Degeneralize server and client generators #1785
Conversation
Pardon the delay, I'm road tripping through Italy for the next two weeks. This will require review when I get back to a laptop, but I think you're right to do this on first glance. Thank you for your effort here. I think the combinations of Config and which modules are enabled should be sufficient to maintain flexibility without the generalized methods, and this would give greater stability to the ABI. The biggest downside is the inability to override a single method, which was the intent of the Perhaps AST transformers in critical locations during generation would preserve customization somehow, but we can cross that bridge when we get there. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1785 +/- ##
==========================================
- Coverage 84.46% 82.41% -2.06%
==========================================
Files 95 93 -2
Lines 5885 7370 +1485
Branches 737 859 +122
==========================================
+ Hits 4971 6074 +1103
- Misses 914 1296 +382
☔ View full report in Codecov by Sentry. |
One of the features that I have struggled to maintain is the ability for the user to override a single method by using This could still be maintained by making all methods As much as I wish it were not necessary, I'm still sympathetic to this change, so with that change I think this can be merged. Hopefully it will increase maintainability enough that the reduction of symmetry between all generators will be worth it. |
6d152b2
to
b2dcefa
Compare
b2dcefa
to
fc1f9b1
Compare
fc1f9b1
to
e69b7c9
Compare
Release notes and migration guide to follow. |
The change degeneralizes the common logic for server/client generation making it possible to have different solutions for different frameworks and simplifying customizations