Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all definitions end up in Swagger.definitions #40

Closed
andrew-domino opened this issue Apr 2, 2018 · 0 comments · Fixed by #41
Closed

Not all definitions end up in Swagger.definitions #40

andrew-domino opened this issue Apr 2, 2018 · 0 comments · Fixed by #41

Comments

@andrew-domino
Copy link
Contributor

While parsing out swagger where definitions are only referenced in additionalProperties the model is never created. This is due to swagger-api/swagger-parser#342 and is fixed in swagger-parser 1.0.34.
trane pushed a commit to trane/guardrail that referenced this issue Apr 2, 2018
@andrew-domino
Update swagger-parser to fix definition parse bug
c2e7d6c 
While parsing swagger with additionalProperties, not all definitions are
resolved in swagger-parser < 1.0.34.
(swagger-api/swagger-parser#602)
This brings us to the most recent version of swagger-parser on the 1.x
line.

Fixes: guardrail-dev#40
@trane trane mentioned this issue Apr 2, 2018
Merged
trane pushed a commit to trane/guardrail that referenced this issue Apr 4, 2018
@andrew-domino
Update swagger-parser to fix definition parse bug
8cdbee9 
While parsing swagger with additionalProperties, not all definitions are
resolved in swagger-parser < 1.0.34.
(swagger-api/swagger-parser#602)
This brings us to the most recent version of swagger-parser on the 1.x
line.

Fixes: guardrail-dev#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update swagger-parser to fix definition parse bug trane/guardrail
1 participant
@andrew-domino