Swimm updates #904
Merged
Swimm updates #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in post_breach/actions/schedule_jobs.py
Codecov Report
@@ Coverage Diff @@
## develop #904 +/- ##
========================================
Coverage 60.56% 60.57%
========================================
Files 166 166
Lines 4953 4954 +1
========================================
+ Hits 3000 3001 +1
Misses 1953 1953
Continue to review full report at Codecov.
|
shreyamalviya
changed the title
ScheduleJobs" Swimm unit
VakarisZ
reviewed
Dec 10, 2020
.travis.yml
Outdated
Comment on lines
57
to
58
| - sudo apt-get -y install libappindicator3-1 | ||
| - sudo apt-get -y install libsecret-1-0 |
There was a problem hiding this comment.
sudo apt-get -f install after dpkg -i swimm should be better, as we wouldn't have to figure out dependencies each time they change
VakarisZ
requested changes
Dec 10, 2020
shreyamalviya
force-pushed
the
swimm-fix
branch
from
c749bc6 to
7d41220
Compare
VakarisZ
reviewed
Dec 14, 2020
.travis.yml
Outdated
| @@ -98,10 +98,11 @@ script: | |||
|
|
|||
| # verify swimm | |||
| - cd $TRAVIS_BUILD_DIR | |||
| - wget https://firebasestorage.googleapis.com/v0/b/swimmio.appspot.com/o/Release%2Fv018%2Fswimm-0.1.8-linux-executable\?alt\=media\&token\=e59c0a18-577f-4b77-bb3b-91b22c3d8b2a -O swimm | |||
| - wget "https://firebasestorage.googleapis.com/v0/b/swimmio.appspot.com/o/Release%2Fv029%2FSwimm_0.2.9_Setup.deb?alt=media&token=774ebd98-cb4e-4615-900c-aada224c1608" -O swimm | |||
| - sudo dpkg -i swimm || (sudo apt-get update && sudo apt-get -f install && sudo dpkg -i swimm) | |||
There was a problem hiding this comment.
do we need the additional sudo dpkg -i swimm at the end? sudo apt-get -f install not enough?
VakarisZ
reviewed
Dec 14, 2020
shreyamalviya
force-pushed
the
swimm-fix
branch
from
7d41220 to
50bec61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "Implement a new PBA —
ScheduleJobs" Swimm unit and modify Travis script for new Swimm version