Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey: Guard against exceptions while fingerprinting #898

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

acepace
Copy link
Contributor

@acepace acepace commented Dec 7, 2020

What does this PR do?

This guards against errors in our fingerprinters that may cause fingerprinting to fail but should not crash monkey

Closes #897

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@acepace acepace added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Monkey labels Dec 7, 2020
@acepace acepace requested a review from VakarisZ December 7, 2020 15:01
@acepace acepace self-assigned this Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #898 (030b1c6) into develop (db20ee1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #898   +/-   ##
========================================
  Coverage    60.56%   60.56%           
========================================
  Files          166      166           
  Lines         4953     4953           
========================================
  Hits          3000     3000           
  Misses        1953     1953           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db20ee1...030b1c6. Read the comment docs.

@acepace acepace merged commit f07826d into guardicore:develop Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fingerprinter exceptions unhandled
2 participants