Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3393 credential pairs configuration #3454

Merged
merged 11 commits into from
Jul 6, 2023

Conversation

ordabach
Copy link
Contributor

@ordabach ordabach commented Jul 3, 2023

What does this PR do?

New propagation's page of the credentials configuration

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@ordabach ordabach force-pushed the 3393-credential-pairs-configuration branch from 6573697 to 0949798 Compare July 5, 2023 13:19
@ordabach ordabach marked this pull request as ready for review July 5, 2023 13:21
Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to add a row that had a public key but no private key.

@mssalvatore
Copy link
Collaborator

We need a way for the user to be able to "unhide" the secrets in the rows so they can see what's actually in the table.

@ordabach ordabach force-pushed the 3393-credential-pairs-configuration branch from 5b0fa49 to 567f227 Compare July 5, 2023 22:31
@ordabach ordabach requested a review from mssalvatore July 5, 2023 22:32
@mssalvatore
Copy link
Collaborator

image
The "Add New credentials" box kind of blends into the table and looks like a header row or something. Can we just make it so it doesn't collapse?

@ordabach ordabach force-pushed the 3393-credential-pairs-configuration branch from d22e778 to f88c78f Compare July 6, 2023 11:52
@mssalvatore mssalvatore merged commit f57752f into develop Jul 6, 2023
@mssalvatore mssalvatore deleted the 3393-credential-pairs-configuration branch July 6, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants