-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3167 pluralize credential collectors #3250
3167 pluralize credential collectors #3250
Conversation
I see that tests pass. Looks like we still have a package named |
Those are going to be removed really soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BB test configurations need to be changed
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
class SSHCredentialCollector(ICredentialCollector): | ||
class SSHCredentialCollector(ICredentialsCollector): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Mimikatz too
class SSHCredentialCollector(ICredentialsCollector): | |
class SSHCredentialsCollector(ICredentialsCollector): |
But I guess we could skip this since they're going to be migrated to plugins soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for skipping for now.
4ccb5b1
to
f5c7818
Compare
What does this PR do?
Fixes part of #3167 .
PR Checklist
Testing Checklist