Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3167 pluralize credential collectors #3250

Merged
merged 10 commits into from
Apr 25, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski commented Apr 25, 2023

What does this PR do?

Fixes part of #3167 .

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@cakekoa
Copy link
Contributor

cakekoa commented Apr 25, 2023

I see that tests pass. Looks like we still have a package named infection_monkey.credential_collectors

@ilija-lazoroski
Copy link
Contributor Author

I see that tests pass. Looks like we still have a package named infection_monkey.credential_collectors

Those are going to be removed really soon.

Copy link
Contributor

@shreyamalviya shreyamalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BB test configurations need to be changed


logger = logging.getLogger(__name__)


class SSHCredentialCollector(ICredentialCollector):
class SSHCredentialCollector(ICredentialsCollector):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Mimikatz too

Suggested change
class SSHCredentialCollector(ICredentialsCollector):
class SSHCredentialsCollector(ICredentialsCollector):

But I guess we could skip this since they're going to be migrated to plugins soon.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for skipping for now.

@mssalvatore mssalvatore force-pushed the 3167-pluralize-credential-collectors branch from 4ccb5b1 to f5c7818 Compare April 25, 2023 14:20
@ilija-lazoroski ilija-lazoroski merged commit 3fbca17 into develop Apr 25, 2023
@mssalvatore mssalvatore deleted the 3167-pluralize-credential-collectors branch April 26, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants