Deletion of the HtmlFieldDescription function #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #3129 +/- ##
========================================
Coverage 71.75% 71.75%
========================================
Files 449 449
Lines 12827 12827
========================================
Hits 9204 9204
Misses 3623 3623 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ordabach
force-pushed
the
3081-delete-html-field-description
branch
from
3e9a9c3 to
20bb67d
Compare
VakarisZ
approved these changes
Mar 21, 2023
| @@ -332,7 +331,6 @@ class ConfigurePageComponent extends AuthComponent { | |||
| selectedSection: this.state.selectedSection | |||
| }) | |||
| formProperties['schema'] = displayedSchema | |||
| formProperties['fields'] = {DescriptionField: HtmlFieldDescription}; | |||
There was a problem hiding this comment.
This isn't needed at all anymore? How does this affect the configuration page?
There was a problem hiding this comment.
Currently, nothing is passed to this property so it doesn't affect anything.
If a need to render dangerous html will be raised in the future we'll create a better solution.
mssalvatore
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to #3081.
Deletion of the HtmlFieldDescription function and its usages due to XSS vulnerability.
PR Checklist
Testing Checklist
If applicable, add screenshots or log transcripts of the feature working