-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2698 plugin selector core #2841
Conversation
For now it mutates only exploiters, we should look for a way to make this extendable to other plugins
@@ -10,7 +10,7 @@ export default function UiSchema(props) { | |||
propagation: { | |||
exploitation: { | |||
exploiters: { | |||
classNames: 'config-template-no-header', | |||
'ui:classNames': 'config-template-no-header', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could've been a separate PR, but for the sake of speed left it here
Codecov ReportBase: 64.53% // Head: 64.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2841 +/- ##
===========================================
+ Coverage 64.53% 64.78% +0.24%
===========================================
Files 414 413 -1
Lines 11743 11752 +9
===========================================
+ Hits 7578 7613 +35
+ Misses 4165 4139 -26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
const EXPLOITERS_SCHEMA_PATH_NEW = 'definitions.ExploitationConfiguration.properties.exploiters'; | ||
const EXPLOITERS_SCHEMA_PATH_LEGACY = 'properties.propagation.properties.exploitation.properties.exploiters'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe distinguishing between UI schema and Island/AgentConfig schema would be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already though about it and it's problematic, because the term UISchema
is already used to define the visual properties of the configuration, it's defined in monkey/monkey_island/cc/ui/src/components/configuration-components/UiSchema.js
. That's how it's called in rjsf
component. I'll add a comment instead
What does this PR do?
Part of #2698
Implements the core of plugin selection logic.
Enables selection/deselection of plugins and changes to their configuration options. On submit/export configuration state contains the changes
Add any further explanations here.
PR Checklist
Testing Checklist