2698 plugin selector UI schema #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 64.47% // Head: 64.47% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #2822 +/- ##
========================================
Coverage 64.47% 64.47%
========================================
Files 411 411
Lines 11698 11698
========================================
Hits 7542 7542
Misses 4156 4156 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mssalvatore
approved these changes
Jan 11, 2023
|
|
||
| function getPluginDisplay(plugin, allPlugins){ | ||
| let selectedPlugin = allPlugins.filter((pluginInArray) => pluginInArray.name == plugin) | ||
| if(selectedPlugin.length === 1){ |
There was a problem hiding this comment.
It's probably impossible for this to be a length other than 0 or 1, but we can code a bit more defensively:
Suggested change
| if(selectedPlugin.length === 1){ | |
| if(selectedPlugin.length > 0){ |
There was a problem hiding this comment.
I'm not sure how much of this code will remain, let's re-consider this once the plugin selector is more fleshed-out
Back end schema contains exploiter plugins, but everything else is missing descriptions etc. Front end has the schema defined well, but it's hard-coded so it can't know what plugins will be added. Until #2750 is resolved merge the schemas
mssalvatore
force-pushed
the
2698-plugin-selector-UI-schema
branch
from
94cfc2c to
50889ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2698
Add any further explanations here.
PR Checklist
Testing Checklist