Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2503 remove telemetry endpoint #2540

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes #2503.

Merge after #2501 is closed

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore mssalvatore force-pushed the 2503-remove-telemetry-endpoint branch from b90ec3f to 29a04d8 Compare November 2, 2022 13:02
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (2501-replace-telemetry-page-component@be7f00e). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head ed1d413 differs from pull request most recent head 29a04d8. Consider uploading reports for the commit 29a04d8 to get more accurate results

Additional details and impacted files
@@                           Coverage Diff                            @@
##             2501-replace-telemetry-page-component    #2540   +/-   ##
========================================================================
  Coverage                                         ?   61.69%           
========================================================================
  Files                                            ?      367           
  Lines                                            ?    11095           
  Branches                                         ?        0           
========================================================================
  Hits                                             ?     6845           
  Misses                                           ?     4250           
  Partials                                         ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the frontend changes tested?

@ilija-lazoroski ilija-lazoroski changed the base branch from 2501-replace-telemetry-page-component to develop November 2, 2022 13:23
@ilija-lazoroski ilija-lazoroski marked this pull request as ready for review November 2, 2022 13:23
@ilija-lazoroski
Copy link
Contributor Author

Were the frontend changes tested?

The stylesheet classes were leftover from the telemetry console and not used anywhere. I didn't see any changes in the UI. Though there were issues on the Island which I think that are going to be resolved in #2507

@mssalvatore mssalvatore merged commit 52d3ea4 into develop Nov 2, 2022
@mssalvatore mssalvatore deleted the 2503-remove-telemetry-endpoint branch November 2, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the /api/telemetry endpoint
2 participants