Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2485 remove the /api/log endpoint #2520

Closed

Conversation

falcon78921
Copy link

@falcon78921 falcon78921 commented Oct 27, 2022

What does this PR do?

Fixes #2485

Became familiar with the monkey project recently. Thought I would contribute what I could, having gone through the setup/codebase.

This PR should remove the /api/log endpoint from Monkey Island. If there's something I'm missing, please let me know and I'll correct.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@falcon78921 falcon78921 changed the title [WIP] Island: remove the /api/log endpoint [WIP] 2485 remove the /api/log endpoint Oct 27, 2022
@falcon78921 falcon78921 force-pushed the 2485/remove-log-endpoint branch from b17fc3d to abaf898 Compare October 27, 2022 18:32
@falcon78921 falcon78921 changed the title [WIP] 2485 remove the /api/log endpoint 2485 remove the /api/log endpoint Oct 27, 2022
Copy link
Contributor

@cakekoa cakekoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @falcon78921, thank you for your contribution to Infection Monkey -- and welcome! The changes look good, but I added one comment. Might as well remove LogService if it's no longer used

@falcon78921 falcon78921 force-pushed the 2485/remove-log-endpoint branch from abaf898 to 8848221 Compare October 27, 2022 21:53
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 61.86% // Head: 61.91% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (8848221) compared to base (1a51ed9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2520      +/-   ##
===========================================
+ Coverage    61.86%   61.91%   +0.04%     
===========================================
  Files          382      379       -3     
  Lines        11341    11292      -49     
===========================================
- Hits          7016     6991      -25     
+ Misses        4325     4301      -24     
Impacted Files Coverage Δ
...ces/reporting/exploitations/manual_exploitation.py 73.68% <0.00%> (-1.32%) ⬇️
monkey/monkey/monkey_island/cc/app.py 77.04% <0.00%> (-0.38%) ⬇️
monkey/monkey/monkey_island/cc/resources/log.py
monkey/monkey/monkey_island/cc/services/log.py
...nkey/monkey_island/cc/services/utils/formatting.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore
Copy link
Collaborator

Merged in commit 25eff5e

@falcon78921 falcon78921 deleted the 2485/remove-log-endpoint branch October 28, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove /api/log endpoint
3 participants