2261 move agent signals to common #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija-lazoroski
requested review from
cakekoa,
mssalvatore and
shreyamalviya
cakekoa
reviewed
Sep 23, 2022
monkey/infection_monkey/island_api_client/i_island_api_client.py
Outdated
Show resolved
Hide resolved
| @@ -36,7 +36,8 @@ def should_agent_stop(self) -> bool: | |||
| if not self._control_channel_server: | |||
| logger.error("Agent should stop because it can't connect to the C&C server.") | |||
| return True | |||
| return self._island_api_client.get_agent_signals(self._agent_id) is not None | |||
| agent_signals = self._island_api_client.get_agent_signals(self._agent_id) | |||
| return agent_signals.terminate is not None | |||
There was a problem hiding this comment.
Should the agent do anything with the timestamp? Why send a timestamp if we're just using it as a bool?
There was a problem hiding this comment.
For now the agent doesn't use it. We may in the future. For example, we can set a hard limit on how long we're willing to wait for the agent to shut down. The agent can compare current time to the signal time and decide whether or not to kill everything.
The other thing is that we don't want the Island to assume how the data will be used. The Island needs to know when a signal was sent so it makes that data available. We don't want the island to send a boolean because that's all the agent needs. The island should just make the data available.
Co-authored-by: Kekoa Kaaikala <[email protected]>
mssalvatore
requested changes
Sep 23, 2022
mssalvatore
approved these changes
Sep 23, 2022
mssalvatore
added a commit
that referenced
this pull request
Sep 23, 2022
…ommon 2261 move agent signals to common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2261 .
PR Checklist
Testing Checklist