Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2261 on terminate agents signal #2337

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Sep 22, 2022

What does this PR do?

Fixes part of #2261.

Implements on_terminate_agents_signal, and connects the AgentSignalsService to the event.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@cakekoa cakekoa changed the base branch from develop to 2261-refactor-manual-agent-logic September 22, 2022 19:48
@ilija-lazoroski ilija-lazoroski force-pushed the 2261-on-terminate-agents-signal branch from 46ac02d to e56fecb Compare September 23, 2022 07:37
@ilija-lazoroski ilija-lazoroski merged commit e51be2e into 2261-refactor-manual-agent-logic Sep 23, 2022
@ilija-lazoroski ilija-lazoroski deleted the 2261-on-terminate-agents-signal branch September 23, 2022 07:53
mssalvatore pushed a commit that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants