1675 remove 32 bit from ssh #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Infection Monkey only supports the x86_64 architecture,there's little use in collecting the architecture from the destination.
Changing the permissions to 777 introduces a security risk into the target host. A malicious attacker with local access can potentially modify the binary, resulting in code execution and privilege escalation when the attacking agent launches the agent on the victim. Issue #1750
This optimization was not functioning properly. This will be refactored and optimized in the near future, so it's not worth the effort to debug this at the present time.
ilija-lazoroski
approved these changes
Feb 28, 2022
| @@ -233,3 +214,13 @@ def _exploit_host(self) -> ExploiterResultData: | |||
|
|
|||
| logger.error(self.exploit_result.error_message) | |||
| return self.exploit_result | |||
|
|
|||
| def _make_agent_executable(self, ftp: paramiko.sftp_client.SFTPClient): | |||
There was a problem hiding this comment.
Lets leave a comment that this can be a part of HostExploiter as we go further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes 32-bit logic from SSHExploiter
Fixes bug in monkey download/propagation
Removes PingScanner from BB config templates
Issue #1675.
PR Checklist
Is the TravisCI build passing?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working