Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1535 netstat info collector removal #1582

Merged
merged 4 commits into from
Nov 12, 2021

Conversation

VakarisZ
Copy link
Contributor

@VakarisZ VakarisZ commented Nov 12, 2021

What does this PR do?

Addresses #1535

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running manually, checking and fixing both attack technique reports, related to netstat check

  • If applicable, add screenshots or log transcripts of the feature working
    image

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1582 (435f52a) into develop (81fb015) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1582      +/-   ##
===========================================
- Coverage    44.78%   44.75%   -0.04%     
===========================================
  Files          475      474       -1     
  Lines        13884    13870      -14     
===========================================
- Hits          6218     6207      -11     
+ Misses        7666     7663       -3     
Impacted Files Coverage Δ
monkey/infection_monkey/system_info/__init__.py 41.66% <0.00%> (-0.96%) ⬇️
...land/cc/services/attack/technique_reports/T1016.py 57.89% <ø> (ø)
...land/cc/services/attack/technique_reports/T1082.py 47.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81fb015...435f52a. Read the comment docs.

@VakarisZ VakarisZ merged commit 6ee1949 into develop Nov 12, 2021
@VakarisZ VakarisZ deleted the 1535-netstat-info-collector-removal branch November 12, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants