Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process list collector removal #1578

Closed
wants to merge 2 commits into from

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Fixes part of #1535

Removes process list collector

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #1578 (3ae8d67) into develop (f5c8db9) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1578      +/-   ##
===========================================
+ Coverage    44.78%   44.85%   +0.07%     
===========================================
  Files          475      474       -1     
  Lines        13884    13862      -22     
===========================================
  Hits          6218     6218              
+ Misses        7666     7644      -22     
Impacted Files Coverage Δ
...fection_monkey/system_info/linux_info_collector.py 0.00% <ø> (ø)
...ction_monkey/system_info/windows_info_collector.py 0.00% <ø> (ø)
...land/cc/services/attack/technique_reports/T1082.py 47.82% <ø> (ø)
...chema/definitions/system_info_collector_classes.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c8db9...3ae8d67. Read the comment docs.

@VakarisZ
Copy link
Contributor Author

Closed, because ZT report uses it to check for antivirus processes

@VakarisZ VakarisZ closed this Nov 12, 2021
@VakarisZ VakarisZ deleted the 1535-process-list-collector-removal branch December 23, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant