Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking monkey on german system language by adding cp850 encoding to ping scanner #1403

Conversation

TRGamer-tech
Copy link
Contributor

@TRGamer-tech TRGamer-tech commented Aug 6, 2021

What does this PR do?

Fixes #1175.

Add encoding cp850 to subprocess of ping scanner.
This adds the ability for the monkey to work on other system languages that use DOS-Latin-1 as encoding.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the Monkey locally on a system using the german (and english of course) system language

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1403 (54e519e) into develop (8e9f564) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1403      +/-   ##
===========================================
- Coverage    40.07%   40.06%   -0.02%     
===========================================
  Files          465      465              
  Lines        13845    13849       +4     
===========================================
  Hits          5548     5548              
- Misses        8297     8301       +4     
Impacted Files Coverage Δ
monkey/infection_monkey/network/ping_scanner.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9f564...54e519e. Read the comment docs.

@mssalvatore mssalvatore force-pushed the 1175/fix-break-on-german-system-lang branch from e57bdca to 41f4fb3 Compare August 13, 2021 12:42
@mssalvatore mssalvatore force-pushed the 1175/fix-break-on-german-system-lang branch from a49dbba to 54e519e Compare August 19, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monkey breaks on German system language
2 participants