Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL warnings #859

Closed
1 task
VakarisZ opened this issue Oct 12, 2020 · 8 comments · Fixed by #1298
Closed
1 task

SSL warnings #859

VakarisZ opened this issue Oct 12, 2020 · 8 comments · Fixed by #1298
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: High

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Oct 12, 2020

Describe the bug

image

To Reproduce

Steps to reproduce the behavior:

  1. Configure the Monkey Island on AWS (maybe happens elsewhere too?)

Expected behavior

Should not be throwing warnings.

Tasks

References

https://stackoverflow.com/questions/66364650/catching-errors-being-thrown-within-module

@VakarisZ VakarisZ added the Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. label Oct 12, 2020
@acepace
Copy link
Contributor

acepace commented Oct 14, 2020

Can't avoid that while using self signed certs. Without control over who's running the island, GC shouldn't sign a blanket cert.

@VakarisZ
Copy link
Contributor Author

I agree with you, but maybe we can ignore/catch the warnings in order not to litter the log and not to confuse users.

@acepace
Copy link
Contributor

acepace commented Oct 19, 2020

Ah, hmm.
This will go away once you use gevent as this warning comes from tornado.

@mxm0z
Copy link

mxm0z commented Dec 17, 2020

I'm having the same issue. I even tried with different environments - debian, vmware, docker. All the same. How can I use gevent to fix this? It's not clear

@VakarisZ
Copy link
Contributor Author

VakarisZ commented Dec 18, 2020

@mxm0z You can't (unless you're running a dev version) but we will on the next release. Also, AFAIK this should not impact your usage of the tool, simply spams the logs.

@VakarisZ
Copy link
Contributor Author

Still happens with gevent, let's try to catch it

@mssalvatore
Copy link
Collaborator

Since we switched to gevent, the error looks like:
image

@shreyamalviya shreyamalviya removed their assignment Jul 1, 2021
mssalvatore added a commit that referenced this issue Jul 5, 2021
By default, gevent prints exceptions and tracebacks to stderr. This is
obnoxious as it results in large tracebacks intermixed with the output
that the logger prints to the console. This commit redirects this data
to {DATA_DIR}/gevent_exceptions.log. Unfortunately, this would mean that
the user might be left without any indication these exceptions had
occurred, unless they take the time to inspect the
gevent_exceptions.log. Therefore, when an excepion occurs, a message
with just the exception (not the traceback) is logged to WARNING.

Fixes #859
mssalvatore added a commit that referenced this issue Jul 5, 2021
By default, gevent prints exceptions and tracebacks to stderr. This is
obnoxious as it results in large tracebacks intermixed with the output
that the logger prints to the console. This commit redirects this data
to {DATA_DIR}/gevent_exceptions.log. Unfortunately, this would mean that
the user might be left without any indication these exceptions had
occurred, unless they take the time to inspect the
gevent_exceptions.log. Therefore, when an excepion occurs, a message
with just the exception (not the traceback) is logged to WARNING.

Fixes #859
@mssalvatore mssalvatore mentioned this issue Jul 5, 2021
7 tasks
@mssalvatore
Copy link
Collaborator

After spending some time with this, I don't think we should entirely suppress this warning. Since users can now provide their own certificates, this could be useful information for them.

What we do need is to prevent the traceback from being displayed in the console output. PR #1298 proposes a solution.

mssalvatore added a commit that referenced this issue Jul 5, 2021
By default, gevent prints exceptions and tracebacks to stderr. This is
obnoxious as it results in large tracebacks intermixed with the output
that the logger prints to the console. This commit redirects this data
to {DATA_DIR}/gevent_exceptions.log. Unfortunately, this would mean that
the user might be left without any indication these exceptions had
occurred, unless they take the time to inspect the
gevent_exceptions.log. Therefore, when an excepion occurs, a message
with just the exception (not the traceback) is logged to WARNING.

Fixes #859
mssalvatore added a commit that referenced this issue Jul 6, 2021
By default, gevent prints exceptions and tracebacks to stderr. This is
obnoxious as it results in large tracebacks intermixed with the output
that the logger prints to the console. This commit redirects this data
to {DATA_DIR}/gevent_exceptions.log. Unfortunately, this would mean that
the user might be left without any indication these exceptions had
occurred, unless they take the time to inspect the
gevent_exceptions.log. Therefore, when an excepion occurs, a message
with just the exception (not the traceback) is logged to WARNING.

Fixes #859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants