Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with GHA #409

Merged
merged 13 commits into from
Oct 18, 2023
Merged

Build with GHA #409

merged 13 commits into from
Oct 18, 2023

Conversation

Georges-GNM
Copy link
Contributor

@Georges-GNM Georges-GNM commented Oct 16, 2023

What does this change?

Adopts GitHub Actions for CI, replacing TeamCity, and using actions riff raff instead of sbt riffraff artifact.

As workflow-frontend relied on a buildInfo provided by sbt riffraff artifact for prout's checks, this PR also adapts some of the logic used for this, following the example in this implementation,

How to test

This branch has been built through GHA and successfully deployed to the code stage, which seems to be working as normal.

How can we measure success/mitigate risks?

Prod gets deployed successfully and workflow continues working. Any issues with the deployment should end up getting rolled back automatically.

Rollout

  • Pause the TeamCity build
  • Merge this PR
  • Adjust branch protection rules, requiring the GHA build to pass before merge
  • Ensure all open PRs are rebased against main to ensure their build runs

@Georges-GNM Georges-GNM marked this pull request as ready for review October 17, 2023 09:23
@Georges-GNM Georges-GNM requested a review from a team as a code owner October 17, 2023 09:23
twrichards
twrichards previously approved these changes Oct 17, 2023
Copy link
Contributor

@twrichards twrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - couple of suggestions though

Just to confirm, does BuildInfo automatically pick-up the environment variable BUILD_NUMBER (whereas it was explicitly passed before)?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Comment on lines +66 to +68
workflow-frontend-fluentbit:
- fluentbit/parsers.conf
- fluentbit/td-agent-bit.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR, but looking forward to when we move to devx-logs (https://trello.com/c/P8JrJLHR/1345-use-devx-logs-for-workflow-frontend)

@Georges-GNM
Copy link
Contributor Author

Georges-GNM commented Oct 17, 2023

LGTM - couple of suggestions though

Just to confirm, does BuildInfo automatically pick-up the environment variable BUILD_NUMBER (whereas it was explicitly passed before)?

Thanks - have revisited the build steps and clarified/split them up a bit.

In terms of the buildinfo stuff - as I understand it, this is so that Prout can check the commitId which gets surfaced in a couple of html files. With this implementation, that should still be happening - the build should get a gitCommitId from the github_sha here. It won't look at the specific number of the build, but prout should still be happy (based on a similar implementation here)

Edit: huh, don't think I've seen a review get "dismissed" from a push before...

twrichards
twrichards previously approved these changes Oct 18, 2023
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
twrichards
twrichards previously approved these changes Oct 18, 2023
.github/workflows/ci.yml Show resolved Hide resolved
@prout-bot
Copy link

Seen on WORKFLOW_PROD (merged by @Georges-GNM 7 minutes and 36 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants