-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with GHA #409
Build with GHA #409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - couple of suggestions though
Just to confirm, does BuildInfo
automatically pick-up the environment variable BUILD_NUMBER
(whereas it was explicitly passed before)?
workflow-frontend-fluentbit: | ||
- fluentbit/parsers.conf | ||
- fluentbit/td-agent-bit.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this PR, but looking forward to when we move to devx-logs
(https://trello.com/c/P8JrJLHR/1345-use-devx-logs-for-workflow-frontend)
Thanks - have revisited the build steps and clarified/split them up a bit. In terms of the buildinfo stuff - as I understand it, this is so that Prout can check the commitId which gets surfaced in a couple of html files. With this implementation, that should still be happening - the build should get a Edit: huh, don't think I've seen a review get "dismissed" from a push before... |
Co-authored-by: Tom Richards <[email protected]>
a567226
to
20ca4a4
Compare
Seen on WORKFLOW_PROD (merged by @Georges-GNM 7 minutes and 36 seconds ago) Please check your changes! |
What does this change?
Adopts GitHub Actions for CI, replacing TeamCity, and using actions riff raff instead of sbt riffraff artifact.
As workflow-frontend relied on a
buildInfo
provided by sbt riffraff artifact for prout's checks, this PR also adapts some of the logic used for this, following the example in this implementation,How to test
This branch has been built through GHA and successfully deployed to the code stage, which seems to be working as normal.
How can we measure success/mitigate risks?
Prod gets deployed successfully and workflow continues working. Any issues with the deployment should end up getting rolled back automatically.
Rollout