Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HEAD requests to the metric-push-api #6732

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jan 27, 2025

What are you doing in this PR?

When we call the metric-push-api, use a HEAD request.

Trello Card

Why are you doing this?

This API now accepts HEAD requests instead of GET requests. See also guardian/support-service-lambdas#2652.

How to test

I've tested locally by forcing an error and can see the metric-push-api invoked as expected.

How can we measure success?

Have we considered potential risks?

Accessibility test checklist

Screenshots

This API now accepts HEAD requests instead of GET requests. See also
guardian/support-service-lambdas#2652.
Copy link
Contributor

Size Change: +150 B (+0.01%)

Total Size: 2.09 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.4 kB +11 B (+0.01%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.3 kB +9 B (+0.01%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB +13 B (+0.01%)
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB +9 B (0%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB +9 B (+0.01%)
./public/compiled-assets/javascripts/error404Page.js 67.3 kB +8 B (+0.01%)
./public/compiled-assets/javascripts/error500Page.js 67.2 kB +9 B (+0.01%)
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB +9 B (+0.01%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB +8 B (+0.01%)
./public/compiled-assets/javascripts/payPalErrorPage.js 66 kB +10 B (+0.02%)
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.6 kB +9 B (+0.01%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73 kB +11 B (+0.02%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB +9 B (+0.01%)
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 226 kB +10 B (0%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB +8 B (+0.01%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB +8 B (+0.01%)
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/186.js 3.35 kB 0 B
./public/compiled-assets/webpack/187.js 20.1 kB 0 B
./public/compiled-assets/webpack/219.js 39.2 kB 0 B
./public/compiled-assets/webpack/3.js 19.2 kB 0 B
./public/compiled-assets/webpack/344.js 2 kB 0 B
./public/compiled-assets/webpack/397.js 10.2 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/719.js 13.5 kB 0 B
./public/compiled-assets/webpack/754.js 9.92 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/9.js 36.3 kB 0 B
./public/compiled-assets/webpack/checkout.js 13.6 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 9.51 kB 0 B
./public/compiled-assets/webpack/oneTimeCheckout.js 9.42 kB 0 B
./public/compiled-assets/webpack/ThankYou.js 1.05 kB 0 B

compressed-size-action

Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clever idea 👍

@tjmw tjmw merged commit a17885c into main Jan 27, 2025
19 checks passed
@tjmw tjmw deleted the tw/metric-push-api-http-method branch January 27, 2025 14:22
@prout-bot
Copy link

Seen on PROD (merged by @tjmw 14 minutes and 42 seconds ago)

Sentry Release: support-client-side, support

tjmw added a commit that referenced this pull request Jan 28, 2025
tjmw added a commit that referenced this pull request Jan 28, 2025
The alarm this was supposed to help quieten down has been noisier than ever
overnight, so revert this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants