Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude subscribe pages from landing page abtests #6718

Merged

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Jan 22, 2025

What are you doing in this PR?

The contributionsOnly ab-test appeared to be allocating users into the test when they were on \subscribe pages as well as landing/checkout/thankyou routes.

It appears tests referencing targetPage: ... allLandingPagesAndThankyouPages were at fault and this regex has been
updated to remove any subscribe (& digitaledition) pages.

The abtestTests.tsx have been widened to test for these scenario's now too.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Size Change: +674 B (+0.03%)

Total Size: 2.35 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.4 kB +47 B (+0.05%)
./public/compiled-assets/javascripts/[countryGroupId]/lazyRouter.js 93.2 kB +46 B (+0.05%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 254 kB +63 B (+0.02%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB -1 B (0%)
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB +67 B (+0.03%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 67.3 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 67.2 kB -1 B (0%)
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB +44 B (+0.03%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB +46 B (+0.05%)
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.6 kB +47 B (+0.06%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73 kB +49 B (+0.07%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB +49 B (+0.04%)
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 226 kB +70 B (+0.03%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB +48 B (+0.03%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB +52 B (+0.06%)
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/186.js 3.35 kB 0 B
./public/compiled-assets/webpack/187.js 20.1 kB +48 B (+0.24%)
./public/compiled-assets/webpack/3.js 19.2 kB 0 B
./public/compiled-assets/webpack/311.js 40.1 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/397.js 10.2 kB 0 B
./public/compiled-assets/webpack/426.js 36.6 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/719.js 13.5 kB 0 B
./public/compiled-assets/webpack/754.js 9.92 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/checkout.js 14.3 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 9.05 kB 0 B
./public/compiled-assets/webpack/oneTimeCheckout.js 10 kB 0 B
./public/compiled-assets/webpack/ThankYou.js 1.08 kB 0 B

compressed-size-action

@paul-daniel-dempsey paul-daniel-dempsey changed the title Excludes subscribe pages from landing page abtests Exclude subscribe pages from landing page abtests Jan 22, 2025
@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team January 22, 2025 17:35
Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tests to give confidence here 👍

@paul-daniel-dempsey paul-daniel-dempsey merged commit 641fff4 into main Jan 23, 2025
19 checks passed
@paul-daniel-dempsey paul-daniel-dempsey deleted the pd/exclude-subscribe-from-landing-page-tests branch January 23, 2025 14:08
@prout-bot
Copy link

Seen on PROD (merged by @paul-daniel-dempsey 9 minutes and 51 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants