-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cookie set by Guardian Ad-Lite purchase to be persistent #6712
Merged
+127
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cookie has also been renamed. It should persist for 7 days. Previously it was a session cookie. This includes a refactoring to support persistent cookies on the checkout in a product specific way.
Size Change: 0 B Total Size: 2.37 MB ℹ️ View Unchanged
|
andrewHEguardian
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice refactor and test 👍
Seen on PROD (merged by @tjmw 9 minutes ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Update the cookie set by the checkout when a user makes a Guardian Ad-Lite purchase to be persistent. It should persist for 7 days. Previously it was a session cookie. This includes a refactoring to support persistent cookies on the checkout in a product specific way.
Trello Card
Why are you doing this?
This gives the user a 7 day grace period to sign in after purchasing.
How to test
Purchase Guardian Ad-Lite in CODE, see that the cookie is set correctly:
For other products, cookies continue to be correctly set as session cookies:
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots