Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate one-time contribution cookie. #6707

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

rupertbates
Copy link
Member

What are you doing in this PR?

We set a cookie after a successful one-time contribution on support-fronted so that the contributor will not see any support messaging on dotcom for 90 days.

In #6643 I switched from using the one-time contribution cookie for this to the gu_hide_support_messaging cookie which is used by dotcom to store the value returned from members-data-api/user-benefits api.

However dotcom will delete this cookie if it exists for non signed in users, so it is not suitable without reworking the behaviour in dotcom which I would rather not do at this point.

This PR reverts the earlier PR, taking account of the fact that the cookie is now set in the new one-time checkout thank you page rather than the old thank you page.

Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Contributor

Size Change: +17 B (0%)

Total Size: 2.37 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.5 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/lazyRouter.js 93.2 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/router.js 254 kB +7 B (0%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.7 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 67.6 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 67.5 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 164 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.9 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 66.1 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.8 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73.2 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 226 kB 0 B
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/186.js 3.35 kB 0 B
./public/compiled-assets/webpack/187.js 21.7 kB 0 B
./public/compiled-assets/webpack/3.js 19.2 kB 0 B
./public/compiled-assets/webpack/311.js 40.1 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/397.js 10.2 kB 0 B
./public/compiled-assets/webpack/426.js 36.6 kB 0 B
./public/compiled-assets/webpack/643.js 22.4 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/754.js 9.97 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/checkout.js 14.3 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 9.05 kB 0 B
./public/compiled-assets/webpack/oneTimeCheckout.js 9.96 kB 0 B
./public/compiled-assets/webpack/ThankYou.js 1.08 kB +10 B (+0.94%)

compressed-size-action

@rupertbates rupertbates merged commit b622ec4 into main Jan 20, 2025
19 checks passed
@rupertbates rupertbates deleted the reinstate-one-time-contribution-cookie branch January 20, 2025 10:46
@prout-bot
Copy link

Seen on PROD (merged by @rupertbates 9 minutes and 59 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants