-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate one-time contribution cookie. #6707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewHEguardian
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
paul-daniel-dempsey
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Size Change: +17 B (0%) Total Size: 2.37 MB ℹ️ View Unchanged
|
Seen on PROD (merged by @rupertbates 9 minutes and 59 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
We set a cookie after a successful one-time contribution on support-fronted so that the contributor will not see any support messaging on dotcom for 90 days.
In #6643 I switched from using the one-time contribution cookie for this to the gu_hide_support_messaging cookie which is used by dotcom to store the value returned from members-data-api/user-benefits api.
However dotcom will delete this cookie if it exists for non signed in users, so it is not suitable without reworking the behaviour in dotcom which I would rather not do at this point.
This PR reverts the earlier PR, taking account of the fact that the cookie is now set in the new one-time checkout thank you page rather than the old thank you page.