-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ab-test: contributions-only tracking passes through landings to checkout, one-time-checkout & thankyou #6698
ab-test: contributions-only tracking passes through landings to checkout, one-time-checkout & thankyou #6698
Conversation
Size Change: +70 B (0%) Total Size: 2.39 MB ℹ️ View Unchanged
|
217cef4
to
b2aa097
Compare
@paul-daniel-dempsey do we not need to pass the I believe this is necessary in order for the ab test initialisation to know whether a user is paricipating the "Contributions Only" amounts test on pages that don't use Redux, such as the generic checkout and one-time-checkout? Without this change a user in the the "Contributions Only" amounts test won't be allocated the |
Ah yes I see how the session storage would mean the participation is tracked on the checkouts although I have a feeling my PR here will stop it working! #6691 😆, lets discuss after stand-up tomorrow. |
Yes, your right, perhaps not best option to rely on session storage especially if can switch it off in future (for regions chnages for example). I think ensuring the abTest initialization has the |
2924066
to
44180d3
Compare
cd9fbfc
to
c18fd57
Compare
…ontributionsOnly, test added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Seen on PROD (merged by @paul-daniel-dempsey 9 minutes and 13 seconds ago)
Sentry Release: support-client-side, support |
What are you doing in this PR?
Pageview tracking added to generic checkout and one-time checkout
Trello Card
How to test
Set
abDefinition.ts:ab-contributionsOnly
test visibiility totrue
https://support.thegulocal.com/int/contribute?country=lb#ab-contributionsOnly=control
https://support.thegulocal.com/int/contribute?country=lb#ab-contributionsOnly=variant
Screenshots