Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sentry to log if pageviewId not available on event listing #6694

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

GHaberis
Copy link
Contributor

@GHaberis GHaberis commented Jan 15, 2025

What are you doing in this PR?

We attach the pageViewId to the URL of the Ticket Tailor iframe as a query string parameter, this allows us to track in the data-lake page view IDs against ticket purchases. However a high percentage (~60%) of ticket purchases in the data-lake have a null page view id. I'd like to rule out this being down to a race condition, where pageViewId is not defined when we construct the URL. I'm using sentry to log instances of pageViewId being falsy.

Trello Card

Copy link
Contributor

Size Change: +17 B (0%)

Total Size: 2.1 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.5 kB +17 B (+0.02%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 259 kB 0 B
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 228 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.7 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 67.6 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 67.5 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 166 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.9 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 66.1 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.9 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73.2 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 225 kB 0 B
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 163 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.1 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/187.js 21.7 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/643.js 22.4 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B

compressed-size-action

Copy link
Member

@tjmw tjmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@GHaberis GHaberis merged commit 1510ef7 into main Jan 15, 2025
19 checks passed
@GHaberis GHaberis deleted the gh-event-page-view-id-logging branch January 15, 2025 14:42
@prout-bot
Copy link

Seen on PROD (merged by @GHaberis 9 minutes and 59 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants