-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade node version from 18 => 20 #5625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.73 MB ℹ️ View Unchanged
|
jamesgorrie
force-pushed
the
bump-node-version-18-20
branch
from
January 22, 2024 12:22
0ce25bc
to
58cdc36
Compare
jamesgorrie
force-pushed
the
bump-node-version-18-20
branch
from
January 22, 2024 12:26
58cdc36
to
9124494
Compare
GHaberis
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Seen on PROD (merged by @jamesgorrie 12 minutes and 6 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Upgrades Node to the latest LTS version (20). 18 is currently in maintenance.
Why are you doing this?
I was hoping to update the
setup-java
action - but realised as part of that release they had bumped to node 20.This is to ensure we have parity across dev / build / prod.
How to test
We had to upgrade CDK, and thus
@guardian/cdk
to have full Node 20 supportsupport-frontend
node app locally