Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade node version from 18 => 20 #5625

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

jamesgorrie
Copy link
Contributor

@jamesgorrie jamesgorrie commented Jan 22, 2024

What are you doing in this PR?

Upgrades Node to the latest LTS version (20). 18 is currently in maintenance.

Why are you doing this?

I was hoping to update the setup-java action - but realised as part of that release they had bumped to node 20.

This is to ensure we have parity across dev / build / prod.

How to test

  • Run CDK locally
    We had to upgrade CDK, and thus @guardian/cdk to have full Node 20 support
  • Run support-frontend node app locally

@jamesgorrie jamesgorrie requested a review from a team January 22, 2024 12:06
Copy link
Contributor

github-actions bot commented Jan 22, 2024

Size Change: 0 B

Total Size: 1.73 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 202 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.8 kB
./public/compiled-assets/javascripts/error404Page.js 67.8 kB
./public/compiled-assets/javascripts/error500Page.js 67.7 kB
./public/compiled-assets/javascripts/favicons.js 616 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 166 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 84.5 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 66.3 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 71.1 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 70.1 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 124 kB
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 257 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 166 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 84.7 kB
./public/compiled-assets/webpack/385.js 81.8 kB
./public/compiled-assets/webpack/67.js 18 kB
./public/compiled-assets/webpack/735.js 2 kB
./public/compiled-assets/webpack/775.js 17.8 kB
./public/compiled-assets/webpack/991.js 2.16 kB

compressed-size-action

@jamesgorrie jamesgorrie force-pushed the bump-node-version-18-20 branch from 0ce25bc to 58cdc36 Compare January 22, 2024 12:22
@jamesgorrie jamesgorrie force-pushed the bump-node-version-18-20 branch from 58cdc36 to 9124494 Compare January 22, 2024 12:26
Copy link
Contributor

@GHaberis GHaberis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jamesgorrie jamesgorrie merged commit ab2766c into main Jan 24, 2024
13 checks passed
@jamesgorrie jamesgorrie deleted the bump-node-version-18-20 branch January 24, 2024 12:40
@prout-bot
Copy link

Seen on PROD (merged by @jamesgorrie 12 minutes and 6 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants