feat: abtest targetpage and caRun used to setup, abtests removed

guardian · Feb 4, 2025 · 2ea0e2e · 2ea0e2e
1 parent e656e6b
commit 2ea0e2e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 27 deletions.
diff --git a/support-frontend/assets/helpers/abTests/__tests__/abtestTest.ts b/support-frontend/assets/helpers/abTests/__tests__/abtestTest.ts
@@ -23,7 +23,6 @@ import type { Audience, Participations, Test, Variant } from '../models';
 const { targetPageMatches } = _;
 const { allLandingPagesAndThankyouPages, genericCheckoutOnly } =
 	pageUrlRegexes.contributions;
-const { digitalEditions } = pageUrlRegexes.subscriptions;
 
 jest.mock('ophan', () => ({
 	record: () => null,
@@ -637,26 +636,6 @@ it('targetPage matching', () => {
 	expect(targetPageMatches('/uk/checkout', genericCheckoutOnly)).toEqual(true);
 	expect(targetPageMatches('/uk/thank-you', genericCheckoutOnly)).toEqual(true);
 	expect(targetPageMatches('/uk/thankyou', genericCheckoutOnly)).toEqual(false);
-	// Digital Edition Checkout
-	expect(
-		targetPageMatches(
-			'/uk/checkout?product=DigitalSubscription&ratePlan=Monthly',
-			digitalEditions,
-		),
-	).toEqual(true);
-	expect(
-		targetPageMatches(
-			'/uk/thank-you?product=DigitalSubscription&ratePlan=Annual&userType=current',
-			digitalEditions,
-		),
-	).toEqual(true);
-	// Digital Edition Landing Page
-	expect(
-		targetPageMatches('/uk/subscribe/digitaledition', digitalEditions),
-	).toEqual(true);
-	expect(
-		targetPageMatches('/uk/subscribe/digitaledition/thankyou', digitalEditions),
-	).toEqual(true);
 });
 
 describe('getAmountsTestVariant', () => {

diff --git a/support-frontend/assets/helpers/abTests/abtestDefinitions.ts b/support-frontend/assets/helpers/abTests/abtestDefinitions.ts
@@ -24,8 +24,6 @@ export const pageUrlRegexes = {
 		},
 		subsWeeklyPages:
 			'(/??/subscribe(\\?.*)?$|/??/subscribe/weekly(\\/checkout)?(\\?.*)?$)',
-		digitalEditions:
-			'(?:/(uk|us|ca|eu|nz|int)/)(subscribe$|subscribe/digitaledition$|subscribe/digitaledition/thankyou$|checkout?(.*DigitalSubscription.*)|thank-you?(.*DigitalSubscription.*))',
 	},
 };
 
@@ -125,15 +123,21 @@ export const tests: Tests = {
 			},
 		],
 		audiences: {
-			ALL: {
+			GBPCountries: {
 				offset: 0,
 				size: 1,
 			},
 		},
 		isActive: true,
 		referrerControlled: false, // ab-test name not needed to be in paramURL
-		seed: 2,
-		targetPage: pageUrlRegexes.subscriptions.digitalEditions,
-		excludeContributionsOnlyCountries: false,
+		seed: 7,
+		targetPage:
+			'(/uk/)(subscribe$|subscribe/digitaledition$|subscribe/digitaledition/thankyou$|checkout|thank-you)', // one-off test using canRun to exclude all products except DigitalSubscription
+		excludeContributionsOnlyCountries: true,
+		canRun: () => {
+			const urlSearchParams = new URLSearchParams(window.location.search);
+			const productParam = urlSearchParams.get('product');
+			return !productParam || productParam === 'DigitalSubscription';
+		},
 	},
 };