Update the Scala version in the generate executable script #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this script includes the hard-coded Scala version, it is essential that this is kept in sync with the Scala version defined in the build.sbt file. We might consider automating this coupling away, but for now I've fixed the reference and added a comment to the build.sbt file so it is less likely these versions drift apart in the future.
akash1810
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Since this script includes the hard-coded Scala version, it is essential that this is kept in sync with the Scala version defined in the build.sbt file. We might consider automating this coupling away, but for now I've fixed the reference and added a comment to the build.sbt file so it is less likely these versions drift apart in the future.
What is the value of this?
The generate-executable script is part of the release process, so this ensures that the program can be released.
Any additional notes?
If this becomes tedious in the future then we can automatically extract the scala version from the build.sbt file, or by inspecting the filesystem structure.