Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendation for specifying Github Actions versions #160

Merged
merged 10 commits into from
Mar 21, 2024

Conversation

chrislomaxjones
Copy link
Contributor

@chrislomaxjones chrislomaxjones commented Mar 14, 2024

What is being recommended?

Add a recommendation for specifying versions of Github Actions in our workflows.

As there wasn't a recommendation for GHA in general, I've added an intentionally brief intro. This could be fleshed out in the future, as required.

What's the context?

This approach was reported by the Coverdrop team (who use it in their project).

Feedback welcome!

@chrislomaxjones chrislomaxjones force-pushed the clj/add-github-actions-sha-rec branch from 8495fbe to 36dcacd Compare March 14, 2024 10:21
@chrislomaxjones chrislomaxjones marked this pull request as ready for review March 14, 2024 10:23
github-actions.md Outdated Show resolved Hide resolved
github-actions.md Outdated Show resolved Hide resolved
github-actions.md Outdated Show resolved Hide resolved
github-actions.md Outdated Show resolved Hide resolved
github-actions.md Show resolved Hide resolved
github-actions.md Outdated Show resolved Hide resolved
@chrislomaxjones chrislomaxjones force-pushed the clj/add-github-actions-sha-rec branch from c98cc76 to 58c4c88 Compare March 20, 2024 09:51
Copy link
Contributor

@NovemberTang NovemberTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work to get this over the line @chrislomaxjones

@chrislomaxjones chrislomaxjones merged commit 8300f0b into main Mar 21, 2024
1 check passed
@chrislomaxjones chrislomaxjones deleted the clj/add-github-actions-sha-rec branch March 21, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants