-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommendation for specifying Github Actions versions #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislomaxjones
force-pushed
the
clj/add-github-actions-sha-rec
branch
from
March 14, 2024 10:21
8495fbe
to
36dcacd
Compare
itsibitzi
reviewed
Mar 14, 2024
itsibitzi
reviewed
Mar 14, 2024
tjsilver
reviewed
Mar 14, 2024
akash1810
reviewed
Mar 14, 2024
akash1810
reviewed
Mar 14, 2024
Add links to place where Github Actions are mentioned in existing recommendations.
chrislomaxjones
force-pushed
the
clj/add-github-actions-sha-rec
branch
from
March 20, 2024 09:51
c98cc76
to
58c4c88
Compare
NovemberTang
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work to get this over the line @chrislomaxjones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being recommended?
Add a recommendation for specifying versions of Github Actions in our workflows.
As there wasn't a recommendation for GHA in general, I've added an intentionally brief intro. This could be fleshed out in the future, as required.
What's the context?
This approach was reported by the Coverdrop team (who use it in their project).
Feedback welcome!