Allow building under Java 21 LTS #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See guardian/scala-steward-public-repos#68 ... we're now running our Scala Steward workflow with Java 21 LTS, which means that all projects that want to have Scala Steward updates (like https://github.com/guardian/mobile-save-for-later) need to be able to build under Java 21 (even if the projects are still _running_ in production on Java 8). Being able to build with Java 21 requires using recent versions of Scala (2.12.18+) and sbt (1.9.0+): https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html#jdk-21-compatibility-notes
rtyley
commented
Mar 14, 2024
| @@ -6,6 +6,9 @@ import scala.collection.immutable | |||
|
|
|||
| val testAndCompileDependencies: String = "test->test;compile->compile" | |||
|
|
|||
| ThisBuild / libraryDependencySchemes += | |||
| "org.scala-lang.modules" %% "scala-xml" % VersionScheme.Always // due to Identity using lift-json | |||
There was a problem hiding this comment.
This is a nasty hack, but necessary as our Identity libraries use lift-json, and lift-json is compiled against an old version of scala-xml.
The hack is used in many Guardian repos!
This was referenced Mar 15, 2024
johnduffell
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See guardian/scala-steward-public-repos#68 ... we're now running our Scala Steward workflow with Java 21 LTS, which means that all projects that want to have Scala Steward updates (like this one) need to be able to build under Java 21 (even if the projects are still running in production on Java 8).
(unfortunately the Scala Steward run failing affects everyone, see guardian/scala-steward-public-repos#60 - so I've removed
mobile-save-for-laterfrom Scala Steward until this PR is merged)Being able to build with Java 21 requires using recent versions of Scala (2.12.18+) and sbt (1.9.0+).